Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2S Config/Step1 #25

Merged
merged 7 commits into from
Sep 18, 2024
Merged

R2S Config/Step1 #25

merged 7 commits into from
Sep 18, 2024

Conversation

anu1217
Copy link
Contributor

@anu1217 anu1217 commented Sep 16, 2024

fixes #23

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring a lot of this out. A few comments here, and curious if you have any evidence of it working?

WC_Layers/Conversion_h5m.py Outdated Show resolved Hide resolved
WC_Layers/Conversion_h5m.py Outdated Show resolved Hide resolved
WC_Layers/Conversion_h5m.py Outdated Show resolved Hide resolved
# unstructured mesh tally .h5m file.
meshtal: Mesh_with_Tally.h5m
# Tally number within the meshtal file containing the fluxes for activation.
tally_num: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant for an unstructured mesh? It doesn't seem like your script to convert from OpenMC to H5M preserves any tally number (which is fine if we don't actually need it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not relevant here--only data from one tally is written to h5m, so the same ALARA input file is printed regardless of which number is chosen here

# mesh this tag must already exist within the file specified in <meshtal>.
flux_tag: FLUX_MESH
# Path to the DAGMC material-laden geometry file (.h5m).
geom: DAGMC_Geometry.h5m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this geometry have materials in it? Where is the script that does that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is material laden. PyNE_Lib.py creates a PyNE material library which is then assigned to the DAG-MC geometry using the uwuw_preproc tool (done inside a terminal).

@anu1217
Copy link
Contributor Author

anu1217 commented Sep 16, 2024

I'd say that this is working in the sense that it is creating a photon source distribution (as in #26), but the source printed at each decay time (source_1.h5m & source_2.h5m) is the same, so this might be something to look into

@anu1217 anu1217 requested a review from gonuke September 17, 2024 18:43
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring some of this out @anu1217

@gonuke gonuke merged commit f12d63b into cnerg:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare R2S configuration and/or model for partial activation
2 participants